Skip to content

Move nswbands, nlwbands to host namelist; initialize number concentration species in initialize_constituents#384

Open
jimmielin wants to merge 2 commits intoESCOMP:mainfrom
jimmielin:hplin/move_rad_namelist_misc
Open

Move nswbands, nlwbands to host namelist; initialize number concentration species in initialize_constituents#384
jimmielin wants to merge 2 commits intoESCOMP:mainfrom
jimmielin:hplin/move_rad_namelist_misc

Conversation

@jimmielin
Copy link
Copy Markdown
Member

@jimmielin jimmielin commented Apr 21, 2026

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:

M       schemes/rrtmgp/rrtmgp_pre_namelist.xml
  - moved nlwbands, nswbands to host-side (no effect on CAM)

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       schemes/rrtmgp/rrtmgp_pre_namelist.xml
  - moved nlwbands, nswbands to host-side (no effect on CAM)
  
M       test/test_schemes/initialize_constituents.F90
  - add number concentration species standard names and logic
  - set qmin for chemistry species based on mozart initialization in CAM.

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

If yes to the above question, describe how this code was validated with the new/modified features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant